[webkit-reviews] review granted: [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend : [Attachment 38474] Implementations, modifications, improvements.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 07:27:51 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16356: [GTK] Integrate GStreamer video with the graphics backend

Attachment 38474: Implementations, modifications, improvements.

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	       // Splitting the capability by comma and taking the first part
> +	       // as capability can be something like "audio/x-wavpack,
> +	       gchar** capability = g_strsplit(gst_caps_to_string(caps), ",",

There's a small leak here - gst_caps_to_string returns a string that needs to
be freed. I will turn this into a GOwnPtr when landing.

Other than that, r=me. I'll land it.

More information about the webkit-reviews mailing list