[webkit-reviews] review requested: [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") : [Attachment 38469] patch: handle "text/uri-list" (Windows only atm), updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 23 23:00:24 PDT 2009


Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 28293: [Chromium] event.datatransfer.getdata("text/uri-list") treated the
same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Attachment 38469: patch: handle "text/uri-list" (Windows only atm), updated
https://bugs.webkit.org/attachment.cgi?id=38469&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Changed patch according to review notes. Also removed a superfluous #include.

Note on layout tests: I actually wrote a test for the functionality that works
fine on Safari Mac, but haven't included it here since Chromium doesn't (yet)
support the necessary interfaces (and it felt strange to include a layout test
and immediately disable it for the platform for which one submits the patch).


More information about the webkit-reviews mailing list