[webkit-reviews] review requested: [Bug 26304] [GTK] Add controls for playing html5 video. : [Attachment 38452] Media controls impl., 1.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 23 06:22:36 PDT 2009


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 26304: [GTK] Add controls for playing html5 video.
https://bugs.webkit.org/show_bug.cgi?id=26304

Attachment 38452: Media controls impl., 1.
https://bugs.webkit.org/attachment.cgi?id=38452&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Implements media controls painting.

>From ChangeLog entry:

	Implements controls for media elements.

	Adds a new initializator to the Color class, which makes it possible
	to initialize Color with a GdkColor and an alpha channel.

	Adds a new loading function to the Image class, loadPlatformThemeIcon,
	which loads only platform theme icons. Available only for the Gtk+
port.
	Also modifies the whole process of loading platform resources so there
	is a maximum sharing of code between this new function and the
	loadPlatformResource function.

	Adds a stylesheet that overrides some of the default style settings of
	the media control panel.

	Changes by this patch in RenderThemeGtk class:
	- media slider thumb's size gets properly adjusted,
	- gtkContainer's 'style-set' signal is connected to the appropriate
callback,
	which forces reinitialization of icons and colors on a style change,
	- implements paintMedia* functions, which now properly paint media
controls.

I believe there can be some style or naming issues, I'll be glad to fix them.


More information about the webkit-reviews mailing list