[webkit-reviews] review granted: [Bug 28663] [Gtk] API for disabling local file access to web URLs : [Attachment 38445] Patch v1

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 28663: [Gtk] API for disabling local file access to web URLs
https://bugs.webkit.org/show_bug.cgi?id=28663

Attachment 38445: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38445&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>      gboolean javascript_can_open_windows_automatically;
>      gboolean enable_offline_web_application_cache;
> +    gboolean enable_universal_access_from_file_uri;

from_file_uriS ?

>  };
>  
>  #define WEBKIT_WEB_SETTINGS_GET_PRIVATE(obj)
(G_TYPE_INSTANCE_GET_PRIVATE((obj), WEBKIT_TYPE_WEB_SETTINGS,
WebKitWebSettingsPrivate))
> @@ -130,7 +131,8 @@ enum {
>      PROP_ENABLE_XSS_AUDITOR,
>      PROP_USER_AGENT,
>      PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY,
> -    PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE
> +    PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE,
> +    PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI

URIS ?

>  };
>  
>  // Create a default user agent string
> @@ -597,7 +599,21 @@ static void
webkit_web_settings_class_init(WebKitWebSettingsClass* klass)
>							    TRUE,
>							    flags));
>  
> -
> +    /**
> +    * WebKitWebSettings:enable-universal-access-from-file-uri
> +    *
> +    * Whether to allow files loaded through file:// URIs universal access to

> +    * pages loaded through non-file schemes.

Isn't it just to all pages?

> +    *
> +    * Since 1.1.13
> +    */
> +    g_object_class_install_property(gobject_class,
> +				      
PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI,
> +				      
g_param_spec_boolean("enable-universal-access-from-file-uri",
> +							    _("Enable universal
access from file URI"),

URIs ?

r=me with the name changes and the doc fixup in case it applies to all pages.