[webkit-reviews] review granted: [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position : [Attachment 38434] editingbehavior.patch

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 28154: clicking below end of text in a textarea moves cursor to wrong
position
https://bugs.webkit.org/show_bug.cgi?id=28154

Attachment 38434: editingbehavior.patch
https://bugs.webkit.org/attachment.cgi?id=38434&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Hi Xan

> +WebCore::EditingBehavior core(WebKitEditingBehavior type)
> +{
> +    return (WebCore::EditingBehavior)type;

Is it possible to use c++ style casts here?

>  
> +typedef enum {
> +    WEBKIT_EDITING_BEHAVIOR_MAC,
> +    WEBKIT_EDITING_BEHAVIOR_WINDOWS
> +} WebKitEditingBehavior;

Is it possible to add a COMPILE_ASSERT for these just in case of future
changes?

Thanks. r=me with those changes.