[webkit-reviews] review denied: [Bug 28614] Unnecessary horizontal scrollbar in Gmail under Chromium. ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode. : [Attachment 38376] Perform layout before checking scrollbar modes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 20:56:47 PDT 2009


Dave Hyatt <hyatt at apple.com> has denied Mark Mentovai <mark at chromium.org>'s
request for review:
Bug 28614: Unnecessary horizontal scrollbar in Gmail under Chromium. 
ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode.
https://bugs.webkit.org/show_bug.cgi?id=28614

Attachment 38376: Perform layout before checking scrollbar modes
https://bugs.webkit.org/attachment.cgi?id=38376&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I am not convinced this is right.  You aren't supposed to just always invoke
visibleContentsResized.

Also note that any change to this logic has to be replicated in
WebDynamicScrollbarsView on Mac to keep the two in sync.

Finally I see no reason to change the word "recur" to "recurse."  They mean
exactly the same thing, and changing around English just because you don't like
it pisses me off.


More information about the webkit-reviews mailing list