[webkit-reviews] review denied: [Bug 27571] [CSS3 Backgrounds and Borders] Add support for the "round" value for background-repeat : [Attachment 38397] Patch for the CSS part of round and space

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Beth Dakin <bdakin at apple.com>'s request for review:
Bug 27571: [CSS3 Backgrounds and Borders] Add support for the "round" value for
background-repeat
https://bugs.webkit.org/show_bug.cgi?id=27571

Attachment 38397: Patch for the CSS part of round and space
https://bugs.webkit.org/attachment.cgi?id=38397&action=review

------- Additional Comments from mitz at webkit.org
This patch makes EFillRepeat values require 3 bits, but does not update the
size of the m_repeat member of FillLayer, so assigning to it will clobber the
m_composite member. Thus I’m r-’ing.

Given bug 28635, I think it will no longer make sense to capture all 16
possible combinations of no-repeat/repeat/space/round with one enum. Instead, I
think you should split m_repeat into two fields, one for horizontal repeat and
one for vertical repeat. Perhaps you should fix bug 28635 first. Then adding
space/round will be simple again (as simple as this patch).