[webkit-reviews] review granted: [Bug 28018] Need to implement Canvas3d/WebGL for 3D rendering : [Attachment 38385] Patch for new Canvas3D files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 15:18:55 PDT 2009

Oliver Hunt <oliver at apple.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 28018: Need to implement Canvas3d/WebGL for 3D rendering

Attachment 38385: Patch for new Canvas3D files

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Files are in the wrong directory :D

Minor style gripe: CanvasObject::CanvasObject -> the member constructors should
be indented

GraphicsContext3D::checkError -> I'd prefer notImplemented() in place of what's
currently there

GraphicsContext3D::reshape -> ASSERT(0) should be ASSERT_NOT_REACHED() or

GraphicsContext3D::texSubImage2D -> We don't check in commented out code

Other than these gripes, r=me -- when landed file a bug on updating to current

More information about the webkit-reviews mailing list