[webkit-reviews] review requested: [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying : [Attachment 38399] [PATCH] Quick Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 21 14:59:40 PDT 2009


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 28623: svn-[un]apply should change directories to the repository root
before [un]applying
https://bugs.webkit.org/show_bug.cgi?id=28623

Attachment 38399: [PATCH] Quick Fix
https://bugs.webkit.org/attachment.cgi?id=38399&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Okay, it turns out that svn-apply and svn-unapply work with git too (with the
exception of an error I ran into with that I attempted to fix svn-unapply). 
Note that this always jumps back to the repository root to apply to patch. 
This is compatible with svn-create-patch.  The optimal solution would be to do
something like what pkasting suggested, to walk up the tree and try each
directory to see if the patch will apply from there.  This would work not only
with patches made from the root, but also manual svn patches that are created
in the middle of the repository.

This was working in my test cases!


More information about the webkit-reviews mailing list