[webkit-reviews] review granted: [Bug 23892] execCommand("Underline") uses CSS even when styleWithCSS has been turned off : [Attachment 38383] isolated code into helper functions

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 23892: execCommand("Underline") uses CSS even when styleWithCSS has been
turned off
https://bugs.webkit.org/show_bug.cgi?id=23892

Attachment 38383: isolated code into helper functions
https://bugs.webkit.org/attachment.cgi?id=38383&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.

Two comments needed here:
+    else
+	 style->removeProperty(propertyID);
+}

1.  That "text-decoration: none" is a noop.
2.  an ASSERT is needed to make sure the property is never !important.