[webkit-reviews] review requested: [Bug 23865] Safari can be frozen by rapidly adding timers : [Attachment 38364] Path to fix UI freeze on long timer queue.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 20 23:39:50 PDT 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 23865: Safari can be frozen by rapidly adding timers
https://bugs.webkit.org/show_bug.cgi?id=23865

Attachment 38364: Path to fix UI freeze on long timer queue.
https://bugs.webkit.org/attachment.cgi?id=38364&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Fix UI freezing by a long timer queue.

The patch addresses the case when UI gets  frozen because there are too many
timers in the queue and the CPU can not process all of them quickly enough and
starves the user input.
This may be more pronounced on platforms like cellphones. The patch also
simplifies the code a little - instead of taking all the ready timers out of
the heap and then processing the copy, it takes them one by one.

The recursive multiplication of timers that eventually causes out-of-memory
condition should be addressed, if feasible, in a separate patch - since it
likely involves some sort of limit on resources. If we need to split this bug,
I can do that.


More information about the webkit-reviews mailing list