[webkit-reviews] review granted: [Bug 28335] HTML5 media elements do not fire waiting events correctly : [Attachment 35241] fix some style issues.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 20 16:46:25 PDT 2009
David Levin <levin at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 28335: HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335
Attachment 35241: fix some style issues.
https://bugs.webkit.org/attachment.cgi?id=35241&action=review
------- Additional Comments from David Levin <levin at chromium.org>
This looks fine to me but I'm also relying a lot on the fact that Eric Carlson
said it looked good.
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2009-08-20 Albert J. Wong <ajwong at chromium.org>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + HTML5 media elements do not fire waiting events correctly
> + https://bugs.webkit.org/show_bug.cgi?id=28335
> +
> + Fire the waiting event before seeking, and fix a case where firing
of
> + the seeked event is missed due when the ready state is changed
during
Remove "due".
More information about the webkit-reviews
mailing list