[webkit-reviews] review granted: [Bug 28494] Some tests using editing.js in editing/execCommand should use runDumpAsTextEditingTest : [Attachment 35227] 3rd submission

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 20 14:57:52 PDT 2009


Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 28494: Some tests using editing.js in editing/execCommand should use
runDumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=28494

Attachment 35227: 3rd submission
https://bugs.webkit.org/attachment.cgi?id=35227&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  Clearly editing.js needs some cleanup.

Style:
795	}
 796	 else {
 797	     execForeColorCommand(color);
 798	 }

LGTM.


More information about the webkit-reviews mailing list