[webkit-reviews] review granted: [Bug 28473] Crashes on sites with lots of images : [Attachment 35197] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 20 14:13:58 PDT 2009

Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 28473: Crashes on sites with lots of images

Attachment 35197: Proposed fix.

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
-    ASSERT(!resource->m_isBeingRevalidated);

It's quite unfortunate that we have to lose this assertion. Even though it can
be untrue in the situation from r42896, it could catch dangerous problems.

I think that much of this mess is caused by a problem with preloading logic -
looks like a script that has already been preloaded is being revalidated once
again afterwards (the main document at LexisNexis includes it twice, and
another iframe also includes it). I tried to investigate this further without
much success - I couldn't make a reduced test case.


More information about the webkit-reviews mailing list