[webkit-reviews] review granted: [Bug 27850] Panning by emulating Mouse Wheel events breaks Google Maps : [Attachment 35221] Take 4 - Cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 20 14:04:21 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 27850: Panning by emulating Mouse Wheel events breaks Google Maps
https://bugs.webkit.org/show_bug.cgi?id=27850
Attachment 35221: Take 4 - Cleanup
https://bugs.webkit.org/attachment.cgi?id=35221&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> + if (!hitScrollbar) {
> + // The hit testing above won't detect if we've hit the main frame's
vertical scrollbar. Check that manually now.
> + RECT webViewRect;
> + GetWindowRect(m_viewWindow, &webViewRect);
> + hitScrollbar |= view->verticalScrollbar() && (gestureBeginPoint.x >
(webViewRect.right -
view->verticalScrollbar()->theme()->scrollbarThickness()));
> + }
No need for |= now. You can just use =.
r=me
More information about the webkit-reviews
mailing list