[webkit-reviews] review requested: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 35216] modifed patch according to Darin's and Eric's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 20 12:07:42 PDT 2009


Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 35216: modifed patch according to Darin's and Eric's comments.
https://bugs.webkit.org/attachment.cgi?id=35216&action=review

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
1. fix the typo 
2. move derefIfNotNull definition before PassRefPtr definition.
3. only #if ... #def inline in derefInNotNull definition.


More information about the webkit-reviews mailing list