[webkit-reviews] review granted: [Bug 26902] postMessage() spec now supports sending arrays of ports : [Attachment 35162] proposed patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 26902: postMessage() spec now supports sending arrays of ports
https://bugs.webkit.org/show_bug.cgi?id=26902

Attachment 35162: proposed patch
https://bugs.webkit.org/attachment.cgi?id=35162&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few things to consider but nothing that couldn't get checked in.


> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> +2009-08-19  Drew Wilson  <atwilson at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   postMessage() spec now supports sending arrays of ports
> +	   https://bugs.webkit.org/show_bug.cgi?id=26902
> +
> +	   Added OwnPtr to VectorTraits so we can store OwnPtrs in Vectors.

Nice.


In WebCore/ChangeLog
  "No new tests, " needs an indentation fix.


> diff --git a/WebCore/dom/MessagePort.cpp b/WebCore/dom/MessagePort.cpp

> +    // Passed-in ports passed validity checks, so we can disentangle them.
> +    MessagePortChannelArray* result = new
MessagePortChannelArray(ports->size());

"result" seems as generic as "i" to me.  portArray?


> +    for (unsigned int i = 0 ; i < ports->size() ; ++i) {
> +	   OwnPtr<MessagePortChannel> channel = (*ports)[i]->disentangle(ec);
> +	   ASSERT(!ec);  // Can't generate exception here if passed above
checks.

One space before end of line comments.	Want to do a patch to cpp_style.py? :)



>
> +PassOwnPtr<MessagePortArray>
MessagePort::entanglePorts(ScriptExecutionContext& context,
PassOwnPtr<MessagePortChannelArray> channels)
> +    MessagePortArray* result = new MessagePortArray(channels->size());

Personal nit: "result"