[webkit-reviews] review denied: [Bug 28490] Allow excluding certain plugins from loading : [Attachment 35205] Proposed patch to implement the plugin loading delegation described in the feature request.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 20 10:25:01 PDT 2009
Eric Seidel <eric at webkit.org> has denied Marius Renn <damarvy at gmail.com>'s
request for review:
Bug 28490: Allow excluding certain plugins from loading
https://bugs.webkit.org/show_bug.cgi?id=28490
Attachment 35205: Proposed patch to implement the plugin loading delegation
described in the feature request.
https://bugs.webkit.org/attachment.cgi?id=35205&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Tabs in the ChangeLog. Numerous style violations. Please use
check-webkit-style if you haven't already.
NULL -> 0
if {
We would likely call them "Clients" in WebCore instead of Delegates. Every
class gets its own header generally.
More information about the webkit-reviews
mailing list