[webkit-reviews] review granted: [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558 : [Attachment 35195] Update patch to fix regressions

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27143: [Gtk][REGRESSION] XHR test failures after r45558
https://bugs.webkit.org/show_bug.cgi?id=27143

Attachment 35195: Update patch to fix regressions
https://bugs.webkit.org/attachment.cgi?id=35195&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    // The content-sniffed callback will handle the response if WebCore
> +    // require us to sniff.
> +    if(statusWillBeHandledBySoup(msg->status_code) || (!handle &&
handle->shouldContentSniff()))

This check is bogus. You should not check !handle, and then dereference it. As
we discussed on IRC, you want this check as part of the outer 'or', possibly as
the first one. Apart from this looks good, so r=me.