[webkit-reviews] review denied: [Bug 28480] Don't let local files access web URLs : [Attachment 35180] Patch v1

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 28480: Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480

Attachment 35180: Patch v1
https://bugs.webkit.org/attachment.cgi?id=35180&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog
> index 5335efb..e01f625 100644
> --- a/WebKit/mac/ChangeLog
> +++ b/WebKit/mac/ChangeLog
> @@ -1,3 +1,13 @@
> +2009-08-19  Adam Barth  <abarth at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Don't let local files access web URLs
> +	   https://bugs.webkit.org/show_bug.cgi?id=28480
> +
> +	   * WebView/WebPreferences.mm:
> +	   (+[WebPreferences initialize]):
> +
>  2009-08-18  Anders Carlsson	<andersca at apple.com>
>  
>	   Reviewed by Adele Peterson.
> diff --git a/WebKit/mac/WebView/WebPreferences.mm
b/WebKit/mac/WebView/WebPreferences.mm
> index 0b40b59..cfd24ef 100644
> --- a/WebKit/mac/WebView/WebPreferences.mm
> +++ b/WebKit/mac/WebView/WebPreferences.mm
> @@ -315,7 +315,11 @@ static WebCacheModel cacheModelForMainBundle(void)
>	   [NSNumber numberWithBool:YES],  WebKitJavaEnabledPreferenceKey,
>	   [NSNumber numberWithBool:YES], 
WebKitJavaScriptEnabledPreferenceKey,
>	   [NSNumber numberWithBool:YES], 
WebKitWebSecurityEnabledPreferenceKey,
> +#if ENABLE(DASHBOARD_SUPPORT)
>	   [NSNumber numberWithBool:YES], 
WebKitAllowUniversalAccessFromFileURLsPreferenceKey,
> +#else
> +	   [NSNumber numberWithBool:NO],  
WebKitAllowUniversalAccessFromFileURLsPreferenceKey,
> +#endif
>	   [NSNumber numberWithBool:YES], 
WebKitJavaScriptCanOpenWindowsAutomaticallyPreferenceKey,
>	   [NSNumber numberWithBool:YES],  WebKitPluginsEnabledPreferenceKey,
>	   [NSNumber numberWithBool:YES],  WebKitDatabasesEnabledPreferenceKey,


Since dashboard support is always compiled in on Mac OS X this still results in
the setting being on for Mac OS X.  A more sensible change may be to use a
linked-on-or-after check to set default value of this preference to YES for
existing applications while newly-written applications would get NO as the
value.

You also appear to have omitted GTK from these changes.