[webkit-reviews] review granted: [Bug 25674] Syntax tree nodes should use arena allocation : [Attachment 35169] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 19:54:05 PDT 2009

Gavin Barraclough <barraclough at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 25674: Syntax tree nodes should use arena allocation

Attachment 35169: patch

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Do objects of type ParserArenaFreeable & ParserArenaDeletable really get
allocated outside of the arena? - if so, this makes me a little sad (or to put
my question slightly more directly, do these classes really need subclass
FastAllocBase, or was this just scaffolding?).

It also seems a little odd to provide two inline forms of makeIdentifier, which
appear to be identical (since one calls the other), other than one being a
member of the arena and the other taking the arena as an argument.  Am I
missing something here? - since they appear interchangeable this just seems
like something that could lead to inconsistency and confusion.

Otherwise all looks awesome, r+.

More information about the webkit-reviews mailing list