[webkit-reviews] review denied: [Bug 28037] SocketStreamHandle interface for WebSocket API : [Attachment 35115] Add SocketStreamHandle interface

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 28037: SocketStreamHandle interface for WebSocket API
https://bugs.webkit.org/show_bug.cgi?id=28037

Attachment 35115: Add SocketStreamHandle interface
https://bugs.webkit.org/attachment.cgi?id=35115&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> diff --git a/WebCore/platform/network/cf/SocketStreamHandle.h
b/WebCore/platform/network/cf/SocketStreamHandle.h
<...>
> +	   KURL m_url;
> +
> +	   // platform specific data
> +	   friend class SocketStreamHandleInternal;
> +	   OwnPtr<SocketStreamHandleInternal> internal;

All data in this file is platform specific, cross-platform data goes to
SocketStreamHandleBase. So, there is no need for SocketStreamHandleInternal any
more.

Everything else looks good to me, but this is something that's best to fix
before landing, so r-.