[webkit-reviews] review canceled: [Bug 28473] Crashes on sites with lots of images : [Attachment 35148] Proposed fix.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 19 17:13:15 PDT 2009
David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 28473: Crashes on sites with lots of images
https://bugs.webkit.org/show_bug.cgi?id=28473
Attachment 35148: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=35148&action=review
------- Additional Comments from David Levin <levin at chromium.org>
I'll try to find another way to do this without abusing CachedResourceHandle.
A few ideas mentioned by ap:
* move switchToRevalidatedResource() before the original resource back to cache
* there are several checks in pruneDeadResources() already, maybe we could add
another check there?
* zero out m_resourceToRevalidate at the time it's deleted using a parent
pointer.
More information about the webkit-reviews
mailing list