[webkit-reviews] review requested: [Bug 28335] HTML5 media elements do not fire waiting events correctly : [Attachment 35156] Address Eric's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 15:56:38 PDT 2009


Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 28335: HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335

Attachment 35156: Address Eric's comments
https://bugs.webkit.org/attachment.cgi?id=35156&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
I updated the CGI file to add support for mime type, and pass the no-cache
header.  I also cleaned up the throttling code a bit, but did it slightly
different than the suggestion.	It seems to work on my box.

The html for the test was cleaned up to be proper html rather than just a
fragment.

The comment has been moved into a <p> tag.

The anit-cache param has been removed since the cache-avoidance behavior is
handled by the no-cache header.


More information about the webkit-reviews mailing list