[webkit-reviews] review requested: [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code : [Attachment 35150] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 27967: Decouple the code that deals with the main DB and quota management
from the rest of the DB code
https://bugs.webkit.org/show_bug.cgi?id=27967

Attachment 35150: patch
https://bugs.webkit.org/attachment.cgi?id=35150&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
The problem was that we used a RefPtr copy of a SecurityOrigin (that was
destroyed as soon as we were out of its scope) instead of using the original
pointer in SQLTransactionClient::didCommitTransaction().

We should probably add a Database::securityOrigin() method and explain in more
details when to use securityOrigin() and when to use securityOriginCopy().
Right now, it is not obvious at all what the difference is, and it's very
tempting to call m_database->securityOriginCopy() instead of
m_database->document()->securityOrigin().