[webkit-reviews] review denied: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 35143] add comments in the code to explain why these two changes are needed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 14:45:10 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 35143: add comments in the code to explain why these two changes are
needed.
https://bugs.webkit.org/attachment.cgi?id=35143&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great!

typo:
 174	 // which will fail compiling when PassRefPtr<T> is used as class
member or fucntion 

if you were a committer I would r+ this and you could fix the typo when
landing.


More information about the webkit-reviews mailing list