[webkit-reviews] review requested: [Bug 27573] [CSS3 Backgrounds and Borders] Add support for the "contain" value for background-size : [Attachment 35132] Patch for the CSS part of contain and cover

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 27573: [CSS3 Backgrounds and Borders] Add support for the "contain" value
for background-size
https://bugs.webkit.org/show_bug.cgi?id=27573

Attachment 35132: Patch for the CSS part of contain and cover
https://bugs.webkit.org/attachment.cgi?id=35132&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a patch for the CSS part of supporting contain and cover as values for
background-size. There are a few things that I am unsure about:

1. Should the code that is share with WebKitMaskSize be broken out so that
WebKitMaskSize does not support contain and cover? Right now, I implemented it
to continue matching background-size.
2. In CSSPrimitiveValueMappings.h I was unsure what to return in the normal
case when the value is a pair of numbers.

Those are the main things, I think.