[webkit-reviews] review granted: [Bug 28441] build error with ICU 4.2.x on Windows + Visual studio : [Attachment 35126] patch : prepend WTF_...ASCIIType_h with 'isXXX' / 'toXXX'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 11:13:04 PDT 2009


Darin Adler <darin at apple.com> has granted Jungshik Shin <jshin at chromium.org>'s
request for review:
Bug 28441: build error with ICU 4.2.x on Windows + Visual studio
https://bugs.webkit.org/show_bug.cgi?id=28441

Attachment 35126: patch : prepend WTF_...ASCIIType_h with 'isXXX' / 'toXXX'
https://bugs.webkit.org/attachment.cgi?id=35126&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems like an OK way to sidestep the build failure. Not a great solution,
but something that will do no harm.

r=me


More information about the webkit-reviews mailing list