[webkit-reviews] review requested: [Bug 28462] Fix linker warnings on Windows : [Attachment 35127] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 10:10:41 PDT 2009

Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 28462: Fix linker warnings on Windows

Attachment 35127: Patch v1

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* WebCore.vcproj/WebCore.vcproj: Exclude JSHTMLDataListElement.cpp
from the build (just like we do for the other generated bindings
files) so that we don't get warnings about multiply-defined symbols in
JSHTMLDataListElement.cpp and DerivedSources.cpp. Also removed
duplicate versions of JSSVGElementWrapperFactory.cpp, and let VS
reorder a few files.
 2 files changed, 59 insertions(+), 92 deletions(-)

More information about the webkit-reviews mailing list