[webkit-reviews] review granted: [Bug 28303] [Qt] XSLT support with QtXmlPatterns : [Attachment 35060] Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 09:31:02 PDT 2009


Eric Seidel <eric at webkit.org> has granted Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 28303: [Qt] XSLT support with QtXmlPatterns
https://bugs.webkit.org/show_bug.cgi?id=28303

Attachment 35060: Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp.
https://bugs.webkit.org/attachment.cgi?id=35060&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems that we will need an XSLStyleSheet.h file anyway.  There is code to be
shared here.

-bool XSLStyleSheet::isLoading()
certainly should be shared.

As should:
-void XSLStyleSheet::checkLoaded()

Possibly:
-void XSLStyleSheet::clearDocuments()

So before you add hte qt version, I think we need to add back an
XSLStyleSheet.h and .cpp file and move a bunch of this code into a shared
baseclass.

The ChangeLog diff is bad, so this will have to be applied manually.  I don't
trust svn-apply to get this right.


More information about the webkit-reviews mailing list