[webkit-reviews] review granted: [Bug 24758] [Gtk] Implement a WebDataSource for the gtk port : [Attachment 34892] Updated WebResource patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 19 03:26:21 PDT 2009
Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758
Attachment 34892: Updated WebResource patch
https://bugs.webkit.org/attachment.cgi?id=34892&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +
> +static void test_webkit_web_resource_get_data(WebResourceFixture* fixture,
gconstpointer data)
> +{
> + GString* charData = webkit_web_resource_get_data(fixture->webResource);
> + g_assert_cmpstr(charData->str, ==, "<html></html>");
> +}
It would be good to do a test with data that has zeros in it.
> + g_object_class_install_property(gobject_class,
> + PROP_URL,
> + g_param_spec_string(
> + "url",
> + _("URL"),
> + _("The url of the resource"),
> + NULL,
> + WEBKIT_PARAM_READABLE));
> +
> + g_object_class_install_property(gobject_class,
> + PROP_MIME_TYPE,
> + g_param_spec_string(
> + "mime-type",
> + _("MIME Type"),
> + _("The MIME type of the resource"),
> + NULL,
> + WEBKIT_PARAM_READABLE));
> +
> + g_object_class_install_property(gobject_class,
> + PROP_TEXT_ENCODING_NAME,
> + g_param_spec_string(
> + "text-encoding-name",
> + _("Text Encoding Name"),
> + _("The text encoding name of the
resource"),
> + NULL,
> + WEBKIT_PARAM_READABLE));
> +
> + g_object_class_install_property(gobject_class,
> + PROP_FRAME_NAME,
> + g_param_spec_string(
> + "frame-name",
> + _("Frame Name"),
> + _("The frame name of the resource"),
> + NULL,
> + WEBKIT_PARAM_READABLE));
Please document the properties before landing this. Otherwise looks great,
r=me.
More information about the webkit-reviews
mailing list