[webkit-reviews] review granted: [Bug 27937] Implement HTML5 nav element : [Attachment 35098] complete patch - with ChangeLog and tests

Tue Aug 18 19:30:45 PDT 2009

Sam Weinig <sam at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 27937: Implement HTML5 nav element
https://bugs.webkit.org/show_bug.cgi?id=27937

Attachment 35098: complete patch - with ChangeLog and tests
https://bugs.webkit.org/attachment.cgi?id=35098&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>  // Checks if a string is a valid tag for the FormatBlockCommand function of
execCommand. Expects lower case strings.
>  bool validBlockTag(const String& blockTag)
>  {
> +    // FIXME: convert this to a HashSet

Eek.  Or at least AtomicStrings.

> +
> Index: LayoutTests/fast/html/nav-element.html
> ===================================================================
> --- LayoutTests/fast/html/nav-element.html	(revision 0)
> +++ LayoutTests/fast/html/nav-element.html	(revision 0)
> @@ -0,0 +1,64 @@
> +<!doctype HTML>

> +
> +</body>
> +</style>
What is this </style> about.

r=me