[webkit-reviews] review granted: [Bug 15743] run-webkit-tests hangs when WebCore tries to log too much : [Attachment 35086] Patch v2

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 15743: run-webkit-tests hangs when WebCore tries to log too much
https://bugs.webkit.org/show_bug.cgi?id=15743

Attachment 35086: Patch v2
https://bugs.webkit.org/attachment.cgi?id=35086&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +    my $actualRead = readFromDumpToolWithTimer(IN, ERROR);

Now that $errorRead doesn't exist, it might be nice to rename this to
$readResults, for example.

> +	       if ($haveSeenEofIn && $haveSeenEofError) {
>		   last;
>	       }

This could be written in a single line as:

    last if $haveSeenEofIn and $haveSeenEofError;

Neither of the above two changes are required, though.

r=me!