[webkit-reviews] review requested: [Bug 28335] HTML5 media elements do not fire waiting events correctly : [Attachment 35076] waiting/seeking fix...Now with a test\!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 14:30:31 PDT 2009


Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 28335: HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335

Attachment 35076: waiting/seeking fix...Now with a test\!
https://bugs.webkit.org/attachment.cgi?id=35076&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
the seeked event is missed due when the ready state is changed during
a seek.

Patch by Albert J. Wong <ajwong at chromium.org> on 2009-08-18
Reviewed by NOBODY (OOPS!).

HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335

Added video-waiting-seeking.html into manual tests because not
all platforms allow seeking into non-buffered ranges.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): add support for
waiting event when seeking.
(WebCore::HTMLMediaElement::finishSeek): send seeked event
whenever seeking finishes.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): dispatch to
new function.
* html/HTMLMediaElement.h:
* manual-tests/video-waiting-seeking.html: Added.

LayoutTests: New manual test to check if waiting/seeking events are fired
when seeking into a non-buffered region.

Patch by Albert J. Wong <ajwong at chromium.org> on 2009-08-18
Reviewed by NOBODY (OOPS!).

HTML5 media elements do not fire waiting events correctly
https://bugs.webkit.org/show_bug.cgi?id=28335

* http/tests/media/video-throttled-load.cgi: Added.
* media/video-test.js:
(isInTimeRanges):
---
 2 files changed, 66 insertions(+), 0 deletions(-)


More information about the webkit-reviews mailing list