[webkit-reviews] review requested: [Bug 28054] use auxillary releaseRef function to get around winscw compiler issue regarding template argument. : [Attachment 35070] Modified patch as per Darin's comments.

[bugzilla-daemon at webkit.org]

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 28054: use auxillary releaseRef function to get around winscw compiler
issue regarding template argument.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 35070: Modified patch as per Darin's comments.
https://bugs.webkit.org/attachment.cgi?id=35070&action=review

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
Thanks for the review!

I modified the patch according to the comments.  For winscw compiler, if inline
is present in derefInNotNull templated function definition, the compiler will
try to resolve deref() and will eventually report error if the argument class T
is not defined before PassRefPtr<T> is used.  Therefore, I had to remove inline
for winscw compiler, and add inline for other compilers to avoid introducing
any performance hit.