[webkit-reviews] review denied: [Bug 27612] handling scripts can block UI : [Attachment 34859] modified for coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 13:17:47 PDT 2009

Antti Koivisto <koivisto at iki.fi> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27612: handling scripts can block UI

Attachment 34859: modified for coding style

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I think CachedScript is wrong place to do this. It is likely have all kinds of
unforeseen side effect. If you want to chop processing to smaller pieces on
scripts that is probably better done in the tokenizer level which already has
logic and timers to do processing in reasonable sized chunks.
HTMLTokenizer::notifyFinished(CachedResource*) might be the place to start

Also I think it should be possible to implement this in a manner that works
well unversally on all platforms and does not require #ifdeffing. The code rot
is pretty certain for this kind of code otherwise.

More information about the webkit-reviews mailing list