[webkit-reviews] review denied: [Bug 28320] SharedWorkers need to forward exceptions to parent documents : [Attachment 34874] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 12:12:06 PDT 2009


David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 28320: SharedWorkers need to forward exceptions to parent documents
https://bugs.webkit.org/show_bug.cgi?id=28320

Attachment 34874: proposed patch
https://bugs.webkit.org/attachment.cgi?id=34874&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It looks good except for one thing: Consider creating a
fast/workers/resources/TEMPLATE and then run
WebKitTools/Scripts/make-script-test-wrappers to generate
shared-worker-exception.html-disabled (You'll likely need to add some
exceptions in that script as well.)


This may not be the right path so if it turns out to be a lot of work speak up.


More information about the webkit-reviews mailing list