[webkit-reviews] review granted: [Bug 28432] String::createCFString() returns a non-retained empty string : [Attachment 35051] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 11:01:55 PDT 2009


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 28432: String::createCFString() returns a non-retained empty string
https://bugs.webkit.org/show_bug.cgi?id=28432

Attachment 35051: proposed patch
https://bugs.webkit.org/attachment.cgi?id=35051&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If either solution is fine speed-wise, then why not call CFRetain to save
memory in case a lot of these strings are kept around?


More information about the webkit-reviews mailing list