[webkit-reviews] review granted: [Bug 28431] Application Cache doesn't work with HTTP authentication : [Attachment 35048] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 18 10:29:42 PDT 2009
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 28431: Application Cache doesn't work with HTTP authentication
https://bugs.webkit.org/show_bug.cgi?id=28431
Attachment 35048: proposed fix
https://bugs.webkit.org/attachment.cgi?id=35048&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + // For normal resource loading, WebKit client is asked about each
resource individually. Since application cache does not belong to any
particular document,
> + // the existing client callback cannot be used, and just assume that any
client that enables application cache also wants it to use credential storage.
Should say "so assume" rather than "and just assume".
r=me
More information about the webkit-reviews
mailing list