[webkit-reviews] review granted: [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code : [Attachment 34873] patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27967: Decouple the code that deals with the main DB and quota management
from the rest of the DB code
https://bugs.webkit.org/show_bug.cgi?id=27967

Attachment 34873: patch
https://bugs.webkit.org/attachment.cgi?id=34873&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks good. A few non-blocking comments below.

> +	   * GNUmakefile.am:
> +	   * WebCore.gypi:
> +	   * WebCore.vcproj/WebCore.vcproj:
> +	   * WebCore.xcodeproj/project.pbxproj:

What about WebCore.pro and other build systems? I am assuming you grepped
through all of them to make sure we won't introduce some port breakage here.

> +	   // Notifies everybody that the transaction was successfully
commited.
> +	   void didCommitTransaction(SQLTransaction*);

I think "Notifies everybody that" is superfluous here and below.

> +
> +	   // Notifies everybody that a statement in the given transaction has
been executed.
> +	   void didExecuteStatement(SQLTransaction*);
> +
> +	   // Notifies everybody that the size of the database file exceeds its
quota.
> +	   // If this method returns true, the current statement in the
transaction is
> +	   // retried. Otherwise, the transaction is rolled back.
> +	   bool didExceedQuota(SQLTransaction*);