[webkit-reviews] review granted: [Bug 28410] Add 'icu::' qualifier to ICU C++ names : [Attachment 35045] patch with ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 09:22:59 PDT 2009


Eric Seidel <eric at webkit.org> has granted Jungshik Shin <jshin at chromium.org>'s
request for review:
Bug 28410: Add 'icu::' qualifier to ICU C++ names
https://bugs.webkit.org/show_bug.cgi?id=28410

Attachment 35045: patch with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=35045&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok, sounds fine.  I wonder if we shouldn't change the rest of our ICU uses to
use icu:: if namespace icu { } is always defined and used by ICU these days.


More information about the webkit-reviews mailing list