[webkit-reviews] review denied: [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled : [Attachment 32410] Code patch for Registerfile ccp and h

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27051: Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
https://bugs.webkit.org/show_bug.cgi?id=27051

Attachment 32410: Code patch for Registerfile ccp and h
https://bugs.webkit.org/attachment.cgi?id=32410&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this needs a comment in the code indicating that this is not the
preferred method.  That platforms should provide instead an allocator which
provides lazy commit.

I'm assuming for the moment that there are no alignment requirements.  If there
are, this patch is invalid for other reasons.

Please track down othermaciej or ggaren over irc for the alignment
requirements.  I'm ready to r+ a change with an added comment about how
fastMalloc does not lazy commit and that platforms should instead provide a
better allocator.