[webkit-reviews] review denied: [Bug 28271] V8 Bindings for Desktop Notifications : [Attachment 34764] V8 Bindings for Notifications

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied John Gregg
<johnnyg at google.com>'s request for review:
Bug 28271: V8 Bindings for Desktop Notifications
https://bugs.webkit.org/show_bug.cgi?id=28271

Attachment 34764: V8 Bindings for Notifications
https://bugs.webkit.org/attachment.cgi?id=34764&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Overall, looks good. Some style nits around abbreviations:

> +    Notification* notif =
V8DOMWrapper::convertToNativeObject<Notification>(V8ClassIndex::NOTIFICATION,
args.Holder());

notification

> +    Notification* notif =
V8DOMWrapper::convertToNativeObject<Notification>(V8ClassIndex::NOTIFICATION,
args.Holder());

notification

> +    NotificationCenter* notifInterface =
V8DOMWrapper::convertToNativeObject<NotificationCenter>(V8ClassIndex::NOTIFICAT
IONCENTER, args.Holder());

notificationCenter

> +    RefPtr<V8CustomVoidCallback> callback;
> +    if (args.Length() > 0) {
> +	   if (!args[0]->IsObject()) {
> +	       V8Proxy::throwError(V8Proxy::TypeError, "Callback must be of
valid type.");
> +	       return v8::Undefined();

return throwError("Callback must...");