[webkit-reviews] review denied: [Bug 28303] [Qt] XSLT support with QtXmlPatterns : [Attachment 34854] [Qt] Implement XSLT support with QtXmlPatterns.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 17 17:45:21 PDT 2009
Eric Seidel <eric at webkit.org> has denied Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 28303: [Qt] XSLT support with QtXmlPatterns
https://bugs.webkit.org/show_bug.cgi?id=28303
Attachment 34854: [Qt] Implement XSLT support with QtXmlPatterns.
https://bugs.webkit.org/attachment.cgi?id=34854&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems we could have a better abstraction here:
#if ENABLE(XSLT)
310 #if ENABLE(XSLT) && !USE(QXMLQUERY)
311311 , m_transformSource(0)
312312 #endif
Style. Likewise, we need a better abstraction:
#if USE(QXMLQUERY)
3757 void Document::setTransformSource(const String &source)
3758 {
3759 m_transformSource = source;
3760 }
3761 #else
If that means having a TransformSource class which is opaque to document,
that's fine.
Abstraction/cleanup needed:
#if ENABLE(XSLT)
183 #if ENABLE(XSLT) && !USE(QXMLQUERY)
184184 void* xmlDocPtrForString(DocLoader*, const String& source, const String&
url);
185185 #endif
Yeah, basically all of the:
44 #if ENABLE(XSLT) && !USE(QXMLQUERY)
look wrong. Or at least they could be done better with just a little bit of
abstraction work.
More information about the webkit-reviews
mailing list