[webkit-reviews] review granted: [Bug 28292] Need to extend DumpRenderTree to expose number of worker threads : [Attachment 34808] patch with fix for gtk type error

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 28292: Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292

Attachment 34808: patch with fix for gtk type error
https://bugs.webkit.org/attachment.cgi?id=34808&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Wow.  I'm just blown away by how thorough this change is.  Really, wow.  I
don't think I would have had the stamina to change all 4 platforms like that.

This is technically a style violation:
 32	    if (layoutTestController.workerThreadCount == 1) {
 33		log("PASS: Worker thread created");
 34	    } else {
 35		log("FAIL: After thread creation:
layoutTestController.workerThreadCount = " +
layoutTestController.workerThreadCount);
 36	    }

As far as I can tell, this all looks correct.  I'm certainly no COM expert, so
there could be errors there, but looks fine to me.