[webkit-reviews] review denied: [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. : [Attachment 34865] Refactor patternWidth and patternOffset calculations from GraphicsContextQt/Cairo/CG.cpp into GraphicsContext.cpp.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 28268: adjustLineToPixelBoundaries used in platform/GraphicsContext
drawLine needs refactoring finished.
https://bugs.webkit.org/show_bug.cgi?id=28268

Attachment 34865: Refactor patternWidth and patternOffset calculations from
GraphicsContextQt/Cairo/CG.cpp into GraphicsContext.cpp.
https://bugs.webkit.org/attachment.cgi?id=34865&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
These functions should be something like "patternOffsetForDashes" and
"patternWidthForDashes" or similarly longer/clearer names.  Then you can use
ful names like "patternOffset" instead of "patOffset" for the locals.

I was at first confused as to what these functions were for until I realized
they only applied to the line decoration/stroke style code paths.

Otherwise the patch looks good.