[webkit-reviews] review denied: [Bug 28339] Arguments::initializeStandardProperties prevents JavaScriptCore compilation. : [Attachment 34965] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 17 13:11:26 PDT 2009


Darin Adler <darin at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28339: Arguments::initializeStandardProperties prevents JavaScriptCore
compilation.
https://bugs.webkit.org/show_bug.cgi?id=28339

Attachment 34965: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34965&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I believe this patch is wrong.

I am almost sure these properties of the Arguments object are needed with or
without a JIT and this has nothing specific to do with JIT. Maybe the build
failure you're seeing has some other cause.

Also, you included Haiku additions to lots of scripts -- that's unrelated to
the rest of the patch.


More information about the webkit-reviews mailing list