[webkit-reviews] review requested: [Bug 9589] WCSS: -wap-accesskey not supported : [Attachment 34971] patch that fixes the comments by the reviewer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 17 09:02:14 PDT 2009
Charles Wei <charles.wei at torchmobile.com.cn> has asked for review:
Bug 9589: WCSS: -wap-accesskey not supported
https://bugs.webkit.org/show_bug.cgi?id=9589
Attachment 34971: patch that fixes the comments by the reviewer
https://bugs.webkit.org/attachment.cgi?id=34971&action=review
------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch is for WCSS -wap-accesskey support.
-wap-accesskey is an extension to CSS2 by OMA, to assign an accesskey for
elements, for easy navigation purpose. pretty much like accesskey attribute of
HTML.
We are limiting the valid accesskey to number 0 ~ 9, # and *, since they are
available on all keypad devices.
This patch differences from the last patch -- 34197 :
1. moved the property name to the WCSS-specific .in file.
2. fixed some bug in parsing.
3. re-designed the accesskey invocation algorithm
4. new test cases designed
More information about the webkit-reviews
mailing list