[webkit-reviews] review requested: [Bug 27256] Geolocation timeout parameter is not correctly applied : [Attachment 34970] Patch 1 for bug 27256

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 17 08:55:26 PDT 2009

steveblock at google.com has asked  for review:
Bug 27256: Geolocation timeout parameter is not correctly applied

Attachment 34970: Patch 1 for bug 27256

------- Additional Comments from steveblock at google.com
Correctly implements Geolocation timeout parameter.

Greg, you mentioned that on iPhone, the call to
GeolocationService::startUpdating may trigger UI to obtain system permissions
for location. Hence it's impossible to apply the timeout parameter in a
meaningful way through the current GeolocationService interface. Currently, the
timeout parameter is not applied at all, so perhaps a reasonable solution is to
ignore timeouts on iPhone by skipping the call to maybeStartTimer? Or we could
skip the call unless we know that system permissions have already been granted?
What do you think?

More information about the webkit-reviews mailing list