[webkit-reviews] review granted: [Bug 28308] allow down-sampling images during decoding : [Attachment 34884] modified as Eric Seidel requires

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 17 08:23:36 PDT 2009


Adam Treat <treat at kde.org> has granted Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 28308: allow down-sampling images during decoding
https://bugs.webkit.org/show_bug.cgi?id=28308

Attachment 34884: modified as Eric Seidel requires
https://bugs.webkit.org/attachment.cgi?id=34884&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
This looks good, but needs a slight clarification on landing.  Basically,
please initialize sourceY after the call to 'jpeg_read_scanlines' to 'int
sourceY = info->output_scanline - 1;' to emphasize that no behavior change has
occurred where the 'IMAGE_DECODER_DOWN_SAMPLING' is not enabled.  Also add
appropriate comment.  r+ with those changes.  Thanks!


More information about the webkit-reviews mailing list